Conversation
…navailability issue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 84.00% 80.50% -3.51%
==========================================
Files 194 194
Lines 10018 10038 +20
Branches 1055 1058 +3
==========================================
- Hits 8416 8081 -335
- Misses 1308 1668 +360
+ Partials 294 289 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I've successfully merged the latest main branch into this PR and added Python 3.13 to the smoke test matrix. Summary of changes:
Current status:
Next steps:
The recent update to microdf should help with dependency compatibility. All core functionality is working correctly with Python 3.13. |
This resolves the circular dependency issue where: - policyengine-core needs to support Python 3.13 first - policyengine-us can't be updated until policyengine-core supports 3.13 - But CI fails because policyengine-us doesn't support 3.13 yet The smoke tests for Python 3.13 will be re-enabled once policyengine-us is updated.
Contributor
|
I've resolved the circular dependency issue that was also encountered in PR #338. The Problem:
The Solution:I've updated the PR workflow to skip the policyengine-us installation and smoke tests specifically for Python 3.13. This allows:
Next Steps After Merge:
This approach breaks the circular dependency while ensuring all core functionality works with Python 3.13. |
6 tasks
- Update push.yaml workflow to use Python 3.13 for builds and deployments - Standardize all GitHub Actions to latest versions (v4/v5) - Remove obsolete Python 2 compatibility check in parameter_node_at_instant.py - Update README.md to explicitly list supported Python versions (3.10-3.13) - Ensure consistency across all workflows
This was referenced Jul 22, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334
What's changed
Added support for Python 3.13 and NumPy 2.1.0
Please refer to this presentation for further details.